Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Structure Overhaul #58

Merged
merged 125 commits into from
Sep 17, 2020
Merged

Data Structure Overhaul #58

merged 125 commits into from
Sep 17, 2020

Conversation

pulsipher
Copy link
Collaborator

This pull request denotes a fundamental change in the underlying structure and internal API. However, the public API remains similar to previous versions and modeling shouldn't be largely unbroken. These changes have greatly improved the performance, address a number of fundamental bugs, unify the structure, enhance the structure for future development, and more.

Notable feature enhancements include:

  • Object distinction between finite, independent, and dependent parameters
  • Ability to define start value functions (e.g., trajectories) for infinite variables
  • Intelligent support management to ensure uniqueness and classification based on how each one is generated
  • More robust and efficient measures that are able to generate supports on demand at the transcription step
  • Much more robust and sophisticated measure evaluation (including analytic evaluation where appropriate)
  • A complete reworking of TranscriptionOpt, making it much more simple and efficient.
  • Queries now support any variable, measure, expression, or constraint
  • A greatly enhanced InfiniteModel structure that is far less verbose than before
  • Much more

This pull request closes the following:

This also addresses #18 and #57.

pulsipher and others added 30 commits April 13, 2020 14:24
wzhangw and others added 24 commits September 11, 2020 17:48
@pulsipher pulsipher added this to the v0.2.0 milestone Sep 17, 2020
Copy link
Collaborator Author

@pulsipher pulsipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #58 into master will decrease coverage by 0.14%.
The diff coverage is 99.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   99.78%   99.64%   -0.15%     
==========================================
  Files          28       33       +5     
  Lines        3272     4179     +907     
==========================================
+ Hits         3265     4164     +899     
- Misses          7       15       +8     
Impacted Files Coverage Δ
src/Collections/Collections.jl 100.00% <ø> (ø)
src/InfiniteOpt.jl 100.00% <ø> (ø)
src/TranscriptionOpt/TranscriptionOpt.jl 100.00% <ø> (ø)
src/measures.jl 99.68% <ø> (-0.32%) ⬇️
src/objective.jl 100.00% <ø> (ø)
src/optimize.jl 100.00% <ø> (ø)
src/point_variables.jl 100.00% <ø> (ø)
src/reduced_variables.jl 100.00% <ø> (ø)
src/results.jl 100.00% <ø> (ø)
src/scalar_parameters.jl 99.43% <ø> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7e56a...e60232b. Read the comment docs.

@pulsipher pulsipher merged commit 94b7dbb into master Sep 17, 2020
@pulsipher pulsipher deleted the data-struct-overhall branch September 17, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment