Make the Debugger a singleton and do not reset the stopframe to None during postmortem. #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during postmortem. This fixes inducer#607. Making the Debugger a singleton should be enough to fix inducer#607. HOWEVER, pytest def postmortem() calls .reset() which resets the stopframe. Somehow, this causes the debugger to stop somewhere inside internal debugger source code, instead of in the code the postmortem should be done. So, this also includes an override of the .reset() method and detects when the debugger is already running and does not reset the stopframe. See also inducer#67.
|
Reproduce issue. Install pytest and pudb.
def test_foo():
breakpoint()
raise Exceptionpytest --pdbcls pudb.debugger:Debugger --pdb --capture=no test.pyNB. The stopframe issue (#52) can also be observed with pytest-pudb using pytest --pudb test.py |
inducer
reviewed
Dec 2, 2024
Comment on lines
+241
to
+250
| import linecache | ||
| linecache.checkcache() | ||
| self.botframe = None | ||
| if not self._pytest_postmortem: | ||
| self.stopframe = None | ||
| else: | ||
| self._pytest_postmortem = False | ||
| self.returnframe = None | ||
| self.quitting = False | ||
| self.stoplineno = 0 |
There was a problem hiding this comment.
Would it be possible to call into Bdb.reset for some of this? We're already copy-pasting too much of Bdb's guts into pudb... (If not, add a comment why not.)
Comment on lines
223
to
224
| # Okay, now we have a debugger | ||
| self._current_debugger.append(self) |
There was a problem hiding this comment.
Could we get rid of _current_debugger in favor of the singleton mechanism?
| Override from Bdb.reset() | ||
|
|
||
| When pytest starts a postmortem analysis, but the debugger is already active, | ||
| calling .reset() in src/_pytest/debugging.py::post_mortem |
There was a problem hiding this comment.
Add Github link to specific version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #607. Making the Debugger a singleton should be enough to fix #607. HOWEVER, pytest def postmortem() calls .reset() which resets the stopframe. Somehow, this causes the debugger to stop somewhere inside internal debugger source code, instead of in the code the postmortem should be done.
So, this also includes an override of the .reset() method and detects when the debugger is already running and does not reset the stopframe. See also #67.