Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AvalonUD support #854

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Adding AvalonUD support #854

merged 7 commits into from
Dec 1, 2023

Conversation

AvalonService
Copy link
Contributor

This is the initial public release of the AvalonUD (Avalon Unified Drivers) drivers that are compatible with the Avalon Instruments StarGO2Pro and StarGO+ controllers.

The release version number is 2.2 since it is aligned to the controllers internal software/firmware version.

It requires the ZeroMQ networking library and for this reason we tried to include it in the requisites script and added a new cmake_modules module.

A CMakeLists.txt file update has also been proposed to enable driver compilation.

We succefully tested build on 32bit Raspbian, 64bit Ubuntu and 64bit Fedora.

indi-avalonud/indi_avalonud_aux.h Outdated Show resolved Hide resolved
@AvalonService
Copy link
Contributor Author

The new INDI style properties have been implemented.
Please check thanks

@AvalonService AvalonService requested a review from knro November 25, 2023 22:45
@knro
Copy link
Collaborator

knro commented Nov 27, 2023

@pawel-soja Do we need to rebuild the CI image to include zeromq dependency for this to work?

cmake_modules/FindZMQ.cmake Outdated Show resolved Hide resolved
@sterne-jaeger
Copy link
Contributor

Is it really a good idea to create a separate directory? Why don't simply merge it into the existing indi-avalon?

@AvalonService
Copy link
Contributor Author

We assumed this was the safest approach since the "avalon" driver is community-provided code for older hardware
while "avalonud" is managed directly by Avalon Instruments and is the official driver for our new controllers.
But obviously we are open to any suggestions...

@sterne-jaeger
Copy link
Contributor

sterne-jaeger commented Nov 29, 2023

But obviously we are open to any suggestions...

As one of the developer of the StarGo driver, I would really appreciate if we use the same base directory. If there are changes necessary to merge the two of them, I'm happy to assist.

@knro
Copy link
Collaborator

knro commented Nov 30, 2023

@TallFurryMan Any idea why this is still failing? I added zeromq to the dependencies and the CI image was rebuilt?

@sterne-jaeger
Copy link
Contributor

@knro it looks like the package libzmq3-dev is missing under Linux.

@knro
Copy link
Collaborator

knro commented Nov 30, 2023

I have under 22.04, it's missing for CI images?

@sterne-jaeger
Copy link
Contributor

I had to add it in my Ubuntu 22.04.03 installation first. No idea whether it is part of the CI already.

@knro
Copy link
Collaborator

knro commented Dec 1, 2023

Will merge this now and hopefully we can fix the CI issue soon.

@knro knro merged commit 2bc98e0 into indilib:master Dec 1, 2023
1 of 4 checks passed
@TallFurryMan
Copy link
Contributor

TallFurryMan commented Dec 1, 2023

I think that the github action 115 on workflow Docker in the indi core repo, triggered by my merged PR, fixed the dependency issue. We'll see the result on the next PR or commit in the indi 3rd party repo, but I'm optimistic, at least for the zmq dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants