SVBONY: Fixed some bugs and added workaround code for SVBONY Camera SDK #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SVBONYBase::grabImage disassembled and embedded in SVBONYBase::workerExposure - Remove unused SVBONYBase::grabImage function svbony_helpers.h - Added processing in preparation for monochrome camera support (monochrome support not yet completed) - Changed Luma to Luma 8 bit and Luma 16 bit
- Added DEBUGLOG output for camera attributes. - Modified to set Bayer pattern to INDI control panel. Modification of SVBONYBase::setupParam - modified to consider the number of channels when allocating buffers Improvement of SVBONYBase::sendImage - Modified to use Helper function to determine whether Bayer is present or not.
- Changed the SDK to set the ROI only if it is different from the current ROI when setting the ROI - Added code to call SVBSetCameraMode function in SVBONYBase::Connect(). This is a workaround code for a bug in the SDK. - Fixed parameter for setting target cooling temperature in SVB_TARGET_TEMPERATURE
* Merge with d1622b9
|
Hi @knro |
|
I am currently traveling so won't be able to resolve any conflicts. Can you
please rebsse?
…On Sun, Oct 15, 2023, 5:01 AM jctk ***@***.***> wrote:
Hi Jasem
I want you to Resolve all Conflicts with my PR.
—
Reply to this email directly, view it on GitHub
<#849 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNVQK6BIPWDGEVHHKG43LTX7NGY3ANCNFSM6AAAAAA6AVVYRM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Okay. I'll try to rebase. |
- Changed the SDK to set the ROI only if it is different from the current ROI when setting the ROI - Added code to call SVBSetCameraMode function in SVBONYBase::Connect(). This is a workaround code for a bug in the SDK. - Fixed parameter for setting target cooling temperature in SVB_TARGET_TEMPERATURE
…thub.com/jctk/indi-3rdparty-jctk into SVBONY_re-implementing_monochrome_format
|
I've rebased this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs and added workaround code for SVBONY Camera SDK
SVBONY re-implementing monochrome camera