Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oasis Filter Wheel driver and update compilation and installation instructions for indi-astroasis #842

Merged
merged 38 commits into from
Oct 2, 2023

Conversation

astroasis
Copy link
Contributor

Update for compilation and installation instructions for indi-astroasis

astroasis added 30 commits May 5, 2023 23:40
…setting, and optimized firmware version info
Support x64, updated for ambient temerature and backlash compensation
@knro
Copy link
Collaborator

knro commented Oct 1, 2023

Thank you. Please update the debian files as well.

@astroasis
Copy link
Contributor Author

Thank you. Please update the debian files as well.

Thanks for your reminder! As I am not familiar with Debian, could you please let me know which particular files I need to update? And if there is any common rules that I can follow to update those files?

Also could you please merge the current PR first and I will update debian files and create another PR later. This is because I have committed more changes on my forked indi-3rdparty source tree. After the current PR is mergered I will create another PR for those changes and then update debian files. I think this can avoid the risk of messing up the code and PRs.

@knro
Copy link
Collaborator

knro commented Oct 1, 2023

Sure, all you need to do is update the Changelog file to reflect the updated version. You do this by adding an entry above the current one and just change version and date/time in the same format.

@astroasis astroasis changed the title Update for compilation and installation instructions for indi-astroasis Add Oasis Filter Wheel driver and update compilation and installation instructions for indi-astroasis Oct 2, 2023
@astroasis
Copy link
Contributor Author

Sure, all you need to do is update the Changelog file to reflect the updated version. You do this by adding an entry above the current one and just change version and date/time in the same format.

Thanks. Now I have updated and commited the changelog file. Also I have changed the title of this PR from
"Update for compilation and installation instructions for indi-astroasis"
to
"Add Oasis Filter Wheel driver and update compilation and installation instructions for indi-astroasis"

@knro
Copy link
Collaborator

knro commented Oct 2, 2023

Thank you. debian/libastroasis probably needs to be updated as well since you updated the library.

@astroasis
Copy link
Contributor Author

Thank you. debian/libastroasis probably needs to be updated as well since you updated the library.

Now I have updated and committed debian/libastroasis/changelog. Thanks!

@knro knro merged commit 7e54b35 into indilib:master Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants