WIP: updated family model -DO NOT MERGE #85
Conversation
putmantime
commented
Nov 29, 2022
putmantime
commented
- added FamilyRelationship Class
- removed family member ids from participant e.g. mother_id
- created relationship_type and corresponding enum
| FamilyRelationship: | ||
| name: FamilyRelationship | ||
| definition_uri: include:FamilyRelationship | ||
| description: Object that captures relationships between the Participants and metadata about that relationship |
There was a problem hiding this comment.
suggested definition: "Object that captures a relationship between the Participant and another member of their family, along with metadata about that relationship."
| description: Participant ID for Participant's father | ||
| title: Father Id | ||
| range: string | ||
| relationship_type: |
There was a problem hiding this comment.
I might name this family_relationship_type - since it specifically holds familial relationships.
| has_participant: | ||
| definition_uri: include:has_participant | ||
| description: Link to a Participant | ||
| title: Has Participant | ||
| range: Participant | ||
| has_relationship: | ||
| definition_uri: include:has_relationship | ||
| description: Link to a Relationship |
There was a problem hiding this comment.
Since the class is now called FamilyRelationship, this should be reflected in the definition, with perhaps a bit more detail, e.g.: "A link to a FamilyRelationship object that describes the nature of a Participant's relationship to another family member."
| @@ -226,13 +235,31 @@ slots: | |||
| title: Race | |||
| range: enum_race | |||
| required: true | |||
| related_participant: | |||
| definition_uri: include:related_participant | |||
| description: Participant related to Subject Participant | |||
There was a problem hiding this comment.
I might add a bit more detail/specificity here, e.g. "A family member to which the Participant is related" . . . unless you mean for this slot to be used more generally to describe any relationship to a participant.
Also, the phrase 'subject participant' might be confusing to those not thinking in terms of a relationship having a subject and object (which I think is the sense of 'subject' you mean here).
| sex: | ||
| definition_uri: include:sex | ||
| description: Sex of participant | ||
| title: Sex | ||
| range: enum_sex | ||
| required: true | ||
| enums: | ||
| enum_relationship_type: |
There was a problem hiding this comment.
Should we name this family_relationship_type to be more precise here?
putmantime
changed the title
