Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Check unknown types and functions in sample applications #88

Closed
wants to merge 1 commit into from
Closed

[RFC] Check unknown types and functions in sample applications #88

wants to merge 1 commit into from

Conversation

lucafavatella
Copy link
Contributor

Please refer to commit message for details.

Check unknown types and functions in sample applications
5533182 
The latest katana-test package 0.1.1 does not include
inaka/katana-test@c3552ed
yet hence the explicit `unknown` option.
@lucafavatella
Copy link
Contributor Author

CI reports the following Dialyzer errors:

@lucafavatella lucafavatella changed the title [WIP] Check unknown types and functions in sample applications [RFC] Check unknown types and functions in sample applications Mar 13, 2017
@lucafavatella
Copy link
Contributor Author

Tagged as request for comments.
Maybe the sample sumo_rest application shall be moved to a separate repo?

@elbrujohalcon
Copy link
Member

I don't particularly like this approach of not including test folder in dialyzer checks, as stated here: inaka/katana-test#38 (comment)

@elbrujohalcon
Copy link
Member

Instead I would prefer to either…

  • add common_test to the PLT
  • add dialyzer(…). attributes to the test modules so that those particular warnings are avoided, and not all of the code unchecked.

@elbrujohalcon
Copy link
Member

inaka/cowboy-trails#74 merged

@lucafavatella lucafavatella mentioned this pull request Mar 13, 2017
Open
@lucafavatella
Copy link
Contributor Author

Thanks for the comments. I am unable to complete this for now - I opened ticket #89 for tracking and I am closing this.

@lucafavatella lucafavatella deleted the check-test-app branch March 13, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucafavatella @elbrujohalcon