Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Act on non_reversible_form as an exception to atom naming conventions #345

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Closes #344.

@elbrujohalcon, not really sure we should make this more explicit with a test (?)

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test would be nice, but we can merge the PR as-is if you like, too.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Jun 5, 2024

I'll update the existing test with a simple thing.

Edit (for b341dbc):

Before

%%% style_SUITE ==> {{badmatch,[#{info => [[],-1,"^^[a-z]([a-zA-Z0-9@]*_?)*(_SUITE)?$"],
              message =>
                  "Atom ~p on line ~p does not respect the format defined by the regular expression '~p'.",
              line_num => -1}]},
 [{style_SUITE,verify_atom_naming_convention,1,
               [{file,"/Users/paulo/Development/contrib/elvis_core/test/style_SUITE.erl"},
                {line,1299}]},
  {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
  {test_server,run_test_case_eval1,6,[{file,"test_server.erl"},{line,1303}]},
  {test_server,run_test_case_eval,9,[{file,"test_server.erl"},{line,1235}]}]}

After

%%% style_SUITE: .

@paulo-ferraz-oliveira
Copy link
Collaborator Author

If the test passes I'm merging with your approval.

@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the fix/non-reversible-feature-form branch from c51bbf6 to cc39163 Compare June 5, 2024 21:21
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the fix/non-reversible-feature-form branch from cc39163 to bf092db Compare June 5, 2024 21:23
@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 7612541 into main Jun 5, 2024
9 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/non-reversible-feature-form branch June 5, 2024 21:26
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with atom on line -1 related to maybe ... end clause
2 participants