Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow checking spaces around | and || #187

Merged
merged 1 commit into from
Mar 21, 2021
Merged

allow checking spaces around | and || #187

merged 1 commit into from
Mar 21, 2021

Conversation

6293
Copy link
Contributor

@6293 6293 commented Mar 21, 2021

No description provided.

elbrujohalcon
elbrujohalcon approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice!

@elbrujohalcon elbrujohalcon merged commit 154b89e into inaka:master Mar 21, 2021
@6293 6293 mentioned this pull request Mar 21, 2021
Merged
@paulo-ferraz-oliveira
Copy link
Collaborator

We should have added tests for when those operators are at line-start and at line-end. It was what was missing before with -> and was left undetected. I'll probably do a more comprehensive tests once I get around to #172. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elbrujohalcon elbrujohalcon elbrujohalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6293 @paulo-ferraz-oliveira @elbrujohalcon