Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider more default operator spaces #172

Closed
paulo-ferraz-oliveira opened this issue Jan 28, 2021 · 5 comments
Closed

Consider more default operator spaces #172

paulo-ferraz-oliveira opened this issue Jan 28, 2021 · 5 comments
Assignees
@elbrujohalcon
Labels
enhancement started
Milestone
2.0.0

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

paulo-ferraz-oliveira commented Jan 28, 2021 •
edited
Loading

(don't want to get into an argument about what is an operator or not 😄)

Should we consider defaults for these?

=
+
-
*
/
%
<
=<
>
>=
==
=:=
/=
=/=
--
=>
:=
<-
<=
||
|
::
->
@elbrujohalcon
Copy link
Member

I like it! I would include all of them in the default, except for ) and (. Those sometimes may require spaces around them, yet sometimes not (I think).

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Cool. I've update the previous list by removing ( and ). It's always a choice to add them in the future, I guess (either as default or on the consumer).

Merged
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Linked to #234, it seems.

@elbrujohalcon elbrujohalcon modified the milestones: 1.3.0, 1.4.0 May 26, 2022
@elbrujohalcon elbrujohalcon self-assigned this Jun 16, 2022
@elbrujohalcon
Copy link
Member

Also, % is not an operator.

elbrujohalcon added a commit that referenced this issue Jun 16, 2022
@elbrujohalcon
Merge pull request #250 from inaka/elbrujohalcon.172.consider_more_de…
8cf1d5f 
…fault_operator

Fix #172: Add many more operators to the default of operator_spaces
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Also, % is not an operator.

I wanted to make sure you were paying attention 🤣 (seriously, though, I don't know where that one came from).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elbrujohalcon elbrujohalcon

Labels
enhancement started
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@elbrujohalcon @paulo-ferraz-oliveira