fix regex, and add new atoms to the test

inaka · Sep 12, 2024 · 61e038c · 61e038c
1 parent 9a7b2b4
commit 61e038c
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 15 deletions.
diff --git a/src/elvis_style.erl b/src/elvis_style.erl
@@ -195,7 +195,7 @@ default(no_common_caveats_call) ->
            {timer, send_interval, 3},
            {erlang, size, 1}]};
 default(atom_naming_convention) ->
-    #{regex => "^([a-z][a-z0-9]*_?)*[a-z0-9]+(_SUITE)?$", enclosed_atoms => ".*"};
+    #{regex => "^[a-z]+((_?[a-z0-9])*[a-z0-9]+)*(_SUITE)?$", enclosed_atoms => ".*"};
 %% Not restrictive. Those who want more restrictions can set it like "^[^_]*$"
 default(numeric_format) ->
     #{regex => ".*",

diff --git a/test/examples/fail_atom_naming_convention.erl b/test/examples/fail_atom_naming_convention.erl
@@ -13,4 +13,10 @@ for_test() ->
     '\'startswithbacktick',
     'backtick\'inside',
     'backtick at the end\'',
-    non200_.
+    non200_,
+    '__', % invalid, even when '_' is actually valid
+    two_underscores__together_are_not_valid,
+    '_something', % invalid because it starts with underscore
+    '42_invalid_because_it_starts_with_a_number',
+    '42invalid', %% even without underscores
+    weDontSupportCamelCaseHere.
diff --git a/test/examples/pass_atom_naming_convention.erl b/test/examples/pass_atom_naming_convention.erl
@@ -6,4 +6,7 @@ for_test() ->
     this_is_an_ok_atom,
     'and_so_is_this',
     'and_this_1_too',
-    non_200.
+    non_200,
+    '_', % used by ets/mnesia/etc.
+    non200, % valid, even without underscores
+    valid_200even_if_numb3rs_appear_between_letters.
diff --git a/test/style_SUITE.erl b/test/style_SUITE.erl
@@ -1302,7 +1302,7 @@ verify_atom_naming_convention(Config) ->
     Group = proplists:get_value(group, Config, erl_files),
     Ext = proplists:get_value(test_file_ext, Config, "erl"),
 
-    BaseRegex = "^([a-z][a-z0-9_]+[a-z0-9])$",
+    BaseRegex = "^[a-z]+((_?[a-z0-9])*[a-z0-9]+)*$",
 
     % pass
     PassModule = pass_atom_naming_convention,
@@ -1337,31 +1337,31 @@ verify_atom_naming_convention(Config) ->
     FailModule2 = fail_atom_naming_convention_exception_class,
     FailPath2 = atom_to_list(FailModule2) ++ "." ++ Ext,
 
-    [_, _, _, _, _, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => BaseRegex, enclosed_atoms => same},
                               FailPath),
-    [_, _, _, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z_]+)$", enclosed_atoms => same},
                               FailPath),
-    [_, _, _] =
+    [_, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z_' \\\\]+)$", enclosed_atoms => same},
                               FailPath),
-    [_, _, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => "^([a-zA-Z\-_]+)$", enclosed_atoms => same},
                               FailPath),
-    [_, _] =
+    [_, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
@@ -1380,26 +1380,26 @@ verify_atom_naming_convention(Config) ->
                               #{regex => BaseRegex, ignore => [FailModule]},
                               FailPath),
     KeepRegex = "^([a-zA-Z0-9_]+)$",
-    [_, _, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => KeepRegex, enclosed_atoms => "^([a-z][a-z0-9A-Z_]*)$"},
                               FailPath),
-    [_, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => KeepRegex,
                                 enclosed_atoms => "^([a-z][a-z0-9A-Z_' \\\\]*)$"},
                               FailPath),
-    [_, _, _, _, _, _, _] =
+    [_, _, _, _, _, _, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
                               #{regex => KeepRegex, enclosed_atoms => "^([a-z][\-a-z0-9A-Z_]*)$"},
                               FailPath),
-    [_, _, _, _] =
+    [_, _, _, _, _, _] =
         elvis_core_apply_rule(Config,
                               elvis_style,
                               atom_naming_convention,
@@ -1414,15 +1414,15 @@ verify_atom_naming_convention(Config) ->
                               FailPath2),
     _ = case Group of
             beam_files -> % 'or_THIS' getting stripped of enclosing '
-                [_, _, _, _] =
+                [_, _, _, _, _, _, _, _] =
                     elvis_core_apply_rule(Config,
                                           elvis_style,
                                           atom_naming_convention,
                                           #{regex => KeepRegex,
                                             enclosed_atoms => "^([\\\\][\-a-z0-9A-Z_' \\\\]*)$"},
                                           FailPath);
             erl_files ->
-                [_, _, _, _, _] =
+                [_, _, _, _, _, _, _, _, _] =
                     elvis_core_apply_rule(Config,
                                           elvis_style,
                                           atom_naming_convention,