Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gun to 2.0.0 #256

Closed
wants to merge 2 commits into from
Closed

Updated gun to 2.0.0 #256

wants to merge 2 commits into from

Conversation

HernanRivasAcosta
Copy link
Member

Based on the work by @jainygaurav on #246 but updated to wok on the newly released 2.0.0 version of cowboy.

@Neustradamus
Copy link

To follow

@elbrujohalcon
Copy link
Member

I allowed CI to run… but now it fails because Gun doesn't work with old erlangs.

@HernanRivasAcosta
Copy link
Member Author

HernanRivasAcosta commented Feb 12, 2023

Because of the fixes to crypto made in Erlang 25.1 I can not make this work on anything earlier than that version.

@ferigis that might mean we should bump this to a new major version since it loses compatibility with the all but the latest Erlang versions.

@HernanRivasAcosta
Copy link
Member Author

@ferigis I'm tempted to merge this PR and increase the version. I've been using this branch for a while now and I can confirm it works perfectly fine, even if the tests are not passing.

What do you think?

@ferigis
Copy link
Member

ferigis commented Mar 7, 2023

hi @HernanRivasAcosta, sorry for the late response.

Yes, lets bump to a major version.

Thanks

@essen
Copy link
Contributor

essen commented May 2, 2023

Please use Gun 2.0.1 so you get a Cowlib version that's compatible with OTP-26 otherwise you'll get a compilation error.

@dsrosario
Copy link
Collaborator

Hello @elbrujohalcon, any plan to approve and merge this PR?

@elbrujohalcon
Copy link
Member

@dsrosario: Not on my side. You should ask @ferigis or @HernanRivasAcosta :)

@dsrosario
Copy link
Collaborator

dsrosario commented Sep 22, 2023

But is there any intension to update the CI to check with latest OTP version (like 26, 25 and 24) instead of the old one's? Maybe some guidance here regarding what Erlang versions to support may help.

gun 2.0.0 is not compatible with OTP20

===> Compiling gun
_build/default/lib/gun/src/gun_socks.erl:142: Warning: a term is constructed, but never used
_build/default/lib/gun/src/gun_socks.erl:147: Warning: a term is constructed, but never used

===> Compiling _build/default/lib/gun/src/gun_http2.erl failed
_build/default/lib/gun/src/gun_http2.erl:922: illegal guard expression

@elbrujohalcon
Copy link
Member

Yeah, usually what we do is to support latest 3 versions. In this case 24, 25 and 26. But, again, I defer to @ferigis and @HernanRivasAcosta for decisions like that on this repo. They're the maintainers and the repo admins.

@dsrosario
Copy link
Collaborator

@ferigis @HernanRivasAcosta any news?

@dsrosario dsrosario closed this Jul 31, 2024
@dsrosario
Copy link
Collaborator

This PR is obsolete. #258 bumped gun to 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants