Skip to content

Commit

Permalink
removed deploy check on running tasks
Browse files Browse the repository at this point in the history
  • Loading branch information
wardviaene committed Feb 24, 2018
1 parent 1614c0e commit 7711f5c
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions provider/ecs/ecs.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import (
"encoding/base64"
"encoding/pem"
"errors"
"fmt"
"math"
"strconv"
"strings"
Expand Down Expand Up @@ -689,22 +688,6 @@ func (e *ECS) LaunchWaitUntilServicesStable(dd *service.DynamoDeployment) error
}
return nil
}
for _, t := range runningService.Tasks {
if t.TaskDefinitionArn == *dd.TaskDefinitionArn && t.LastStatus != "RUNNING" {
reason := fmt.Sprintf("Deployment failed: found task with taskdefinition %v and status %v (expected RUNNING)", t.TaskDefinitionArn, t.LastStatus)
ecsLogger.Debugf(reason)
err := s.SetDeploymentStatusWithReason(dd, "failed", reason)
if err != nil {
return err
}
err = e.Rollback(dd.DeployData.Cluster, dd.ServiceName)
if err != nil {
return err
}
return nil
}
ecsLogger.Debugf("Found task with taskdefinition %v and status %v", t.TaskDefinitionArn, t.LastStatus)
}
if failed {
s.SetDeploymentStatusWithReason(dd, "failed", "Deployment timed out")
return nil
Expand Down

0 comments on commit 7711f5c

Please sign in to comment.