Fixing incorrect error message on Verify #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaosinthecrd <[email protected]>
jkjell
previously approved these changes
Jan 9, 2024
|
just fyi I am currently working on improving how we handle required flags. Maybe we should save the merge until I finish? shouldn't take long. |
Signed-off-by: chaosinthecrd <[email protected]>
Signed-off-by: chaosinthecrd <[email protected]>
jkjell
reviewed
Jan 9, 2024
|
These changes look good. Can we get the merge conflicts sorted, change Aditya recommended, and lining fixed up so this can get merged? |
…file-error Signed-off-by: chaosinthecrd <[email protected]>
Signed-off-by: chaosinthecrd <[email protected]>
✅ Deploy Preview for witness-project canceled.
|
Signed-off-by: chaosinthecrd <[email protected]>
Signed-off-by: chaosinthecrd <[email protected]>
Signed-off-by: chaosinthecrd <[email protected]>
…itness into fixing-policy-file-error
jkjell
reviewed
Apr 5, 2024
Signed-off-by: chaosinthecrd <[email protected]>
jkjell
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed error message seems to have been copied from
cmd/sign.goand is a confusing error to present to the user. Instead it should be specified that the policy file can't be opened.