Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability fixes for KubeCon NA '23 demo #16

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

marcelamelara
Copy link
Contributor

This PR adds various readability and user-friendliness fixes suggested in #13, as well as some extra documentation about the KubeCon NA '23 demo.

@marcelamelara marcelamelara force-pushed the kubecon-demo-readability branch from 653e420 to 4907983 Compare November 2, 2023 00:26
@marcelamelara marcelamelara marked this pull request as ready for review November 2, 2023 00:26
@marcelamelara marcelamelara force-pushed the kubecon-demo-readability branch 5 times, most recently from c9526ee to 10eb1f7 Compare November 2, 2023 01:00
Copy link
Member

@adityasaky adityasaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This largely looks fine minus some minor changes.

docs/kubecon-na-23.md Outdated Show resolved Hide resolved
docs/kubecon-na-23.md Outdated Show resolved Hide resolved
scai-gen/fileio/common.go Show resolved Hide resolved
scai-gen/fileio/pb.go Outdated Show resolved Hide resolved
…tput directory on any file write

Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
Signed-off-by: Marcela Melara <[email protected]>
@marcelamelara marcelamelara force-pushed the kubecon-demo-readability branch from adacade to 49d5ea6 Compare November 2, 2023 17:06
@marcelamelara marcelamelara merged commit f17d36e into in-toto:main Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants