Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docsy-based version of website #53

Merged
merged 18 commits into from
Sep 5, 2024
Merged

Docsy-based version of website #53

merged 18 commits into from
Sep 5, 2024

Conversation

DarikshaAnsari
Copy link
Contributor

chalin
chalin requested changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good start, but you created the PR over the wrong branch. It is currently over main (see the screenshot below), but the PR needs to be over the docsy branch.

image

Also carefully review the updated files to ensure that you're not doing inappropriate overrides. One example is the README.md override which replaces the current correct content with "# Docsy-based in-toto.io site", which is not what we want.

I'll submit more detailed feedback once you resubmit the PR over the docsy branch.

chalin
chalin reviewed Aug 30, 2024
View reviewed changes
netlify.toml Outdated Show resolved Hide resolved
@DarikshaAnsari DarikshaAnsari changed the base branch from main to docsy August 30, 2024 14:03
@chalin chalin changed the title Added all my work from local docsy repo to docsy branch Docsy-based version of website Aug 30, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for in-toto ready!

Name Link
🔨 Latest commit b938e15
🔍 Latest deploy log https://app.netlify.com/sites/in-toto/deploys/66da44fe82e35b0008729994
😎 Deploy Preview https://deploy-preview-53--in-toto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DarikshaAnsari
changed contributing.md
7ff788b 
Signed-off-by: Dariksha <[email protected]>
chalin
chalin reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments, see inline.

.gitignore Outdated Show resolved Hide resolved
static/_redirects Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
archetypes/default.md Outdated Show resolved Hide resolved
chalin
chalin reviewed Aug 30, 2024
View reviewed changes
content/en/News/_index.md Outdated Show resolved Hide resolved
@chalin chalin force-pushed the patch-docsy branch 3 times, most recently from dfd4d0d to 2e057ad Compare September 5, 2024 23:28
chalin and others added 10 commits September 5, 2024 19:28
@chalin
Update .gitignore
0b6fe89 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Update _redirects
da438a9 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Update CONTRIBUTING.md
e02c84d 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Update news.md
f07e5b2 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Delete assets/scss/_tabs.scss
5a892ea 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Update _styles_project.scss: add missing import
8adc248 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Update security-audit-23.md
e8cdbc2 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Preserve original website file names of logos where possible
9637326 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Rename img folder
fb0868a 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Delete unused images and format SVGs
93bf577 
Signed-off-by: Patrice Chalin <[email protected]>
chalin and others added 2 commits September 5, 2024 19:36
@chalin
Update community-lists.html
b938e15 
Signed-off-by: Patrice Chalin <[email protected]>
chalin
chalin approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afer some cleanup (see below), this LGTM. We'll need some followup work. I'll create some issues to track what needs to be done.

Cleanup details:

image

@chalin chalin merged commit 84c2572 into in-toto:docsy Sep 5, 2024
5 checks passed
@chalin chalin mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Umbrella Issue: CNCF Tech Doc Recommendations
2 participants
@DarikshaAnsari @chalin