fix: repetitive and incorrect log lines on witness verify
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch) Signed-off-by: chaosinthecrd <[email protected]>
jkjell
approved these changes
Aug 12, 2024
5 tasks
mikhailswift
added a commit
that referenced
this pull request
Aug 22, 2024
…317)" This reverts commit 26ee2dc. This commit breaks policy evaluations, causing good policies to fail. Signed-off-by: Mikhail Swift <[email protected]>
mikhailswift
added a commit
that referenced
this pull request
Aug 23, 2024
…317)" This reverts commit 26ee2dc. This commit breaks policy evaluations, causing good policies to fail. Signed-off-by: Mikhail Swift <[email protected]>
mikhailswift
added a commit
that referenced
this pull request
Aug 23, 2024
…317)" This reverts commit 26ee2dc. This commit breaks policy evaluations, causing good policies to fail. Signed-off-by: Mikhail Swift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR closes #316 where repeated verification lines existed that looked repeated. It also fixes log lines incorrectly reporting that certain attestations weren't seen. It does so by:
Which issue(s) this PR fixes (optional)
#316
Other Notes
This PR will be supplemented by a small PR (update: in-toto/witness#485) in https://github.com/in-toto/witness. While it is possible to test this without that branch, some of the reported log lines will still seem slightly misleading / confusing.