-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding function for adding a single attestor #104
Closed
+13
−0
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
90292ed
adding function to add a single attestor
ChaosInTheCRD 2a9cd8d
Fixing bug introduced in logs - warning and debug logs not printing (…
ChaosInTheCRD 7e5dc35
Point to v0.2.0 of archivista (#105)
jkjell 9fa0a5a
Create SECURITY.md (#107)
jkjell 210da2a
chore: bump github/codeql-action from 2.22.9 to 3.22.11 (#110)
dependabot[bot] a2db58c
chore: bump actions/download-artifact from 3.0.2 to 4.0.0 (#112)
dependabot[bot] af8e161
chore: bump actions/upload-artifact from 3.1.3 to 4.0.0 (#111)
dependabot[bot] efa0140
chore: bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#115)
dependabot[bot] 736674d
chore: bump github.com/go-git/go-git/v5 from 5.5.2 to 5.11.0 (#119)
dependabot[bot] ab18e20
chore: bump github/codeql-action from 3.22.11 to 3.22.12 (#118)
dependabot[bot] a106144
chore: bump actions/download-artifact from 4.0.0 to 4.1.0 (#117)
dependabot[bot] 1dd0166
chore: bump k8s.io/apimachinery from 0.26.11 to 0.26.12 (#116)
dependabot[bot] a037e9f
Update SECURITY-INSIGHTS.yml with additional information (#108)
jkjell 0185ffa
chore: bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 (#121)
dependabot[bot] 44c86b2
chore: bump actions/dependency-review-action from 3.1.4 to 3.1.5 (#123)
dependabot[bot] 0824d9c
chore: bump github/codeql-action from 3.22.12 to 3.23.0 (#122)
dependabot[bot] 9684b66
fix: added oidc redirect url option for fulcio (#76)
pkwiatkowski1 08bf768
chore: bump actions/upload-artifact from 4.0.0 to 4.1.0 (#126)
dependabot[bot] 0adde0e
chore: bump actions/download-artifact from 4.1.0 to 4.1.1 (#127)
dependabot[bot] 4ebd16e
added old function with deprecation warning
ChaosInTheCRD 144e8c6
Merge branch 'main' into adding-add-attestor
ChaosInTheCRD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it breaks compatibility with previous versions. (I see you fix it in in-toto/witness#332)
How will we document for other users of go-witness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we would need to keep a
func Attestors
with a deprecation notice that just calls AddAttestors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick thing -- The
Attestors
function currently would be more equivalent to aGetAttestors
function -- it's returning a slice of instantiated Attestors from the factory.AddAttestor
, to me, seems to imply we're adding more attestors to the factory.