Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ITE-10 to reflect actual schema #56

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

nmiyake
Copy link
Contributor

@nmiyake nmiyake commented Jul 10, 2024

Updates schema values in ITE-10 to reflect the actual values as specified in the in-toto spec and updates the newly proposed field to match the existing style.

@nmiyake nmiyake requested a review from a team as a code owner July 10, 2024 16:54
@nmiyake
Copy link
Contributor Author

nmiyake commented Jul 10, 2024

@adityasaky this is per discussion on https://github.com/in-toto/ITE/pull/50/files#r1651465773.

I personally prefer camelCase as a style and think that the core in-toto layout file format itself could stand to have a revamp of its definition (for example, _type field seems unneeded, and it would be nice to have a full JSON schema definition for the layout file in a single format/place rather than having it spread through the spec), but I think that changing the file format itself would be a separate independent ITE.

In the meantime, given that this ITE is based on the v1.0.0 spec, I think it's confusing for it to refer to the "existing schema" with field name formatting that doesn't match the actual spec.

@adityasaky adityasaky self-requested a review July 11, 2024 17:12
@adityasaky
Copy link
Member

@nmiyake sorry for the lengthy turnaround on this, could you rebase with DCO? Thanks!

@adityasaky
Copy link
Member

Thanks @nmiyake!

@adityasaky adityasaky merged commit 74ae008 into in-toto:master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants