-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests after #236 and cleanup push_pr workflow #237
base: master
Are you sure you want to change the base?
Conversation
|
|
The "slow" tests cannot run on their own, at least how it's currently set up, because it needs to load the sequence into the TestSequence object first with |
Yeah, realized that as well. I introduced a "required_for_slow" marker and then use |
okay, in the 3rd try on my local PC the slow / plot tests failed as well because of some random tkinter error. 4th run was okay, again. However, in the GitHub workflow it seems buggy. Takes ages. IMO we should just remove the current plot tests (and the slow marker) completely. It doesn't really tests anything anyway, does it? Instead I would introduce some dedicated tests for the plot() functionality at some point. Would you be fine with that @FrankZijlstra ? If not, I will just leave it as it was before and simply don't run the tests. |
All in all, this hopefully simplifies the testing process, removes unnecessary complexity, and is generally better structured.