feat: update OpenID4VCI to WG Draft 12 #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
3 tasks
nanderstabel
added
the
Breaking change
The example files are taken from here: https://github.com/openid/OpenID4VCI/tree/4ae490afd6955829b4769cb1b547e9e62c824659/examples `oid4vci/tests/examples/issuer_metadata.json` is removed as it does not comply anymore with the new `CredentialIssuerMetadata` struct.
as described here: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-12.html#section-10.2.3-2.11.1 Also changed `Option<Vec<T>>` to `Vec<T>` for simplicity since `#[serde(skip_serializing_if = "Vec::is_empty", default)]` ensures the field is not serialized if it's empty.
test files are taken from here: https://github.com/openid/OpenID4VCI/tree/1b7cd7426c42dd8d78db3261ed2e85a520ec7041/examples
In the previous solution using: `#[serde(tag = "type", rename = "openid_credential")]`. instances of this struct were correctly serialized, but deserialization was not working as expected. This was due to the fact that serde(tag) does not work when deserializing.
nanderstabel
force-pushed
the
feat/oid4vci-wg-draft-12
branch
from
55cb215 to
5dc5c8b
Compare
…entialOfferParameters` as described here: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#section-4.1.1-2.2
* `user_pin_required` is replaced for `tx_code` in the `pre-authorized_code` grant type. * Corresponding changes are made in the unit tests
the `format` field is not used anymore in the `CredentialResponse` struct, as described here: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-13.html#name-credential-response
This replaces some encryption related fields in `CredentialIssuerMetadata` as described here: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-13.html#section-11.2.3-2.7.1
…alg_values_supported` as described here: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-13.html#section-11.2.3-2.11.2.4
…pportedObject` struct
…ch with testfiles
…onding test file
…ionRequestDetails` * fix testfiles * as described here: https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-13.html#name-request-issuance-of-a-certa
|
Closing this PR in favor of #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change updates the
oid4vcicrate in order to conform to OpenID4VCI WG Draft 12Links to any relevant issues
#59
How the change has been tested
No tests are added, but existing tests are updated.
Several test fixtures are updated in
oid4vci/tests/examples/*.jsonThese fixtures are copied from here: https://github.com/openid/OpenID4VCI/tree/1b7cd7426c42dd8d78db3261ed2e85a520ec7041/examples
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.