-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pre-authorized code flow #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
force-pushed
the
feat/initial-vci-support
branch
from
July 21, 2023 07:56
28ef59f
to
5a75380
Compare
nanderstabel
changed the title
feat: add first pre-authorized code flow
feat: add pre-authorized code flow
Jul 25, 2023
1 task
daniel-mader
previously approved these changes
Aug 7, 2023
daniel-mader
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces the Pre-Authorized Code Flow as described in Section 3.5 of the OpenID4VCI specification. The flow is fully implemented from the perspective of the
Wallet
. From the Credential Issuer side there is still work to do.CredentialIssuerManager
:oid4vc-manager/src/managers/credential_issuer.rs
Server
forCredentialIssuerManager
:oid4vc-manager/src/servers/credential_issuer.rs
Storage
(oid4vc-manager/src/storage.rs
) trait currently functions a helper trait and sort of represents the server api logic for the Credential Issuer.oid4vc-manager/tests/oid4vci/authorization_code.rs
, however it is not feature complete yet. This will be fixed in: Support OID4VCI Authorization Code Flow #46.oid4vc-manager/tests/oid4vci/pre_authorized_code.rs
.oid4vci/src/credential_format_profiles/mod.rs
.Wallet
implementation can be found inoid4vci/src/wallet/mod.rs
.Links to any relevant issues
#46
closes #45
How the change has been tested
Two integration tests are added for both flows. They can be found in
oid4vc-manager/tests
.All/most new oid4vci related structs are extensively unit-tested (mainly (de)serialization) with the help of the oid4vci spec provided examples here: https://bitbucket.org/openid/connect/src/master/openid-4-verifiable-credential-issuance/examples/.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.