[sc-24168] Add cargo-dylint

[frondeus]

cargo-dylint is a tool for compiling, linking and running dynamically linked, custom lints in our workspace.

Tested on:

• My machine cross compiling from aarch64 to x86
  • Not only tested ./build.sh but also I put .zip in the docker-image-dev, and used impero-dev:dev in ./tools/do_bash.sh to run cargo dylint --all - with a success.
• Jonathan's machine cross compiling from x86 to aarch64
• This CI workflow, compiling all targets.

[arnodb]

Looks good to me but I'd like the thing to be tested before you tag tools and modify docker-image-dev. Unfortunately this is the least documented procedure.

First you need to build an x86_64.zip (or the one for your arch).

Then you need to copy it in your working copy of docker-image-dev.

Then you need to patch the Dockerfile for testing purpose only:

--- a/Dockerfile
+++ b/Dockerfile
@@ -55,12 +55,10 @@ ENV RUSTUP_HOME=/root/.rustup
 WORKDIR /usr/src/impero
 RUN curl https://sh.rustup.rs -sSf \
     | sh -s -- --profile minimal --default-toolchain "$RUST_TOOLCHAIN" -y
+Copy x86_64.zip x86_64.zip
 # Fetch tools needed for development
 RUN ARCH="$(uname -m)"; \
-    TAG="5.1"; \
-    URL="https://github.com/impero-com/docker-image-tools/releases/download/$TAG/$ARCH.zip"; \
     MOLD_VERSION="1.4.1"; \
-    curl -OL -H 'Accept: application/octet-stream' $URL && \
     unzip $ARCH.zip && rm $ARCH.zip && \
     chmod -R +x $ARCH && mv $ARCH/* $HOME/.cargo/bin/ && rm -r $ARCH && \
     curl -OL "https://github.com/rui314/mold/releases/download/v$MOLD_VERSION/mold-$MOLD_VERSION-$ARCH-linux.tar.gz" && \

Then you need to build the image on your machine.

And then you need to test by patching the impero docker-compose.yml file (change the image tag).

Once happy:

• don't forget to revert dev changes
• merge tools, tag tools, wait...
• bump TAG in docker-image-dev
• don't forget to actually test the presence of the new tools (see end of Dockerfile of docker-image-dev)
• open PR, merge, tag, wait...
• use the image tag in docker-compose.yml and in all workflows of impero

[frondeus]

this is on purpose - dylint tools relies on rustup (even for --help, I made a ticket in GH for that), and since we don't have rustup in the worker (we do have inside of a docker), we can fake it by setting this env variable.

[frondeus]

trailofbits/dylint#1172