Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect parameter used by XSH RR in 128 bits. #15

Merged
merged 1 commit into from
May 25, 2019

Conversation

sunoru
Copy link
Contributor

@sunoru sunoru commented Jun 14, 2016

@imneme
Copy link
Owner

imneme commented May 25, 2019

You're right!

Verified against the C++ library using pcg_detail::mcg_base<uint64_t, pcg_detail::pcg128_t, pcg_detail::xsh_rr_mixin>.

(Usually people use XSL-RR for 64-bits, so this probably hasn't been an issue for many people.)

@imneme imneme merged commit 4b6f580 into imneme:master May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants