-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlockSupplier API and block algorithm improvements #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imglib2.version -> 7.1.1 imglib2-roi -> 0.15.1 bigdataviewer-core -> 10.6.1 Remove obsolete bigdataviewer-vistools dependency.
…ementation. Add BlockProcessorTargetInterval wrapper.
TilingBlockSupplier wraps a source BlockSupplier, and splits large BlockSupplier. copy requests into several smaller copy calls on the source BlockSupplier. Example use cases: - Computing large outputs (e. g. to write to N5 or wrap as ArrayImg) with operators that have better performance with smaller block sizes. - Avoiding excessively large blocks when chaining downsampling operators.
downsample by averaging over arbitrarily sized blocks (like in BDV export)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1)
Add new
BlockSupplier
default methodthat takes a
Function
that produces aUnaryBlockOperator
which is then append to the currentBlockSupplier
. (The function can pick an operator based on the type and dimensions of the currentBlockSupplier
.)This allows to write, e.g.,
(2)
Refactoring and augment existing block algorithm (Convert, Downsample, Transform):
T
to be converted toFloatType
. When at runtimeT
already isFloatType
, that is a no-op now.)(3)
Add
TilingBlockSupplier
andBlockSupplier.tile(int...)
default method.TilingBlockSupplier
wraps a sourceBlockSupplier
, and splits largecopy
requests into several smallercopy
calls on the sourceBlockSupplier
.Example use cases: