Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #47

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Refactoring #47

merged 8 commits into from
Jun 21, 2024

Conversation

imclerran
Copy link
Owner

  • Move all state transition logic out of Model module and into Controller
  • Remove redundant paginate calls in state transition functions (already from called from main immediately before rendering)
  • Code cleanup

@imclerran
pull handle input out of runUiLoop into own function
c222359
@imclerran
write getActions function more concisely
b72ff6b
@imclerran
roc format
b18c479
@imclerran
Move all state transition logic into controller
7e6d770 
- general code cleanup
- add defaultHandler in Controller
- remove redundant paginate calls in state transitions (already called once in main before rendering view)
@imclerran
roc format
a939dd3
@imclerran
Rename TextConfirm to TextSubmit
d713f3a
@imclerran
Make sure to update menu in state transition (even though paginate wi…
508a217 
…ll update later from fullMenu)
@imclerran
Begin transitioning tests to new API
25cf0dc 
- model transitions are not directly exposed anymore, must use Controller.applyAction
@imclerran imclerran merged commit 8712d31 into main Jun 21, 2024
1 check passed
@imclerran imclerran deleted the refactoring branch June 21, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imclerran