-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options to mean, median and variance #471
Conversation
6c4eb1f
to
86d1988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variance will return the result of a 0-division if the array of points is empty. Did you think about what should happen in that case?
Same question is relevant for the other operations. |
Indeed this should throw. Should we also check the validity of a coordinate? Right now the user can input any value there, regardless whether the point belongs to an image or not. |
I agree
I think it should throw as well. To be efficient, I suggest that you first convert the points to indices so that you don't do it twice, checking their value (compare with Please add test cases for each of those scenarios (no points, invalid points). |
close: #470