Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

463 add pad function #465

Merged
merged 9 commits into from
May 27, 2024
Merged

463 add pad function #465

merged 9 commits into from
May 27, 2024

Conversation

EscapedGibbon
Copy link
Collaborator

close: #463

@EscapedGibbon EscapedGibbon linked an issue May 24, 2024 that may be closed by this pull request
add pad() function #463
Closed
@EscapedGibbon EscapedGibbon marked this pull request as ready for review May 24, 2024 14:48
@EscapedGibbon
Copy link
Collaborator Author

There is a function that already does what we discussed and it's called extendBorders. I exported it but there are some concerns about naming. Do we keep extendBorders or rename it to pad?

stropitek
stropitek approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with extendBorders

LGTM modulo @targos's review

@stropitek stropitek requested a review from targos May 27, 2024 12:09
@targos targos merged commit 1225b4d into main May 27, 2024
8 checks passed
@targos targos deleted the 463-add-pad-function branch May 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stropitek stropitek stropitek approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add pad() function
3 participants
@EscapedGibbon @targos @stropitek