Rails 7.2 update #312
Rails 7.2 update #312
Conversation
vprigent
force-pushed
the
rails-7.2-update
branch
from
eee89d8 to
22c2776
Compare
lib/data_migrate/rails_helper.rb
Outdated
| @@ -54,7 +63,9 @@ def data_schema_delete_version(version) | |||
| end | |||
|
|
|||
| def data_schema_migration | |||
| if rails_version_equal_to_or_higher_than_7_1 | |||
| if rails_version_equal_to_or_higher_than_7_2 | |||
| DataMigrate::DataSchemaMigration.new(ActiveRecord::Tasks::DatabaseTasks.migration_connection.pool) | |||
There was a problem hiding this comment.
Base on Rails' code, would it be fair to use #migration_connection_pool instead?
There was a problem hiding this comment.
Good call, turns out ActiveRecord::Base also has connection_pool over connection.pool 👍
Changelog.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## 9.5.0 | |||
| - Support Rails 7.2 | |||
There was a problem hiding this comment.
Could you add your PR change link here also?
|
I agree, we should follow Rails' cadence and drop Ruby 3.0 too. Should we go to version 10 then? |
Good point, I'll leave that decision to one of the contributors. perhaps @ngan would be able to review and cut a new version if they deem relevant? |
|
Rails 7.2 came out and now the lack of this fix is causing issues. Would be nice to get just about anything at this point |
|
Why is not possible to merge this? |
|
Hey folks, previous maintainers are no longer able to main the gem and I've been out of Rails ecosystem for many years now. So looking for someone willing to take over maintaining this gem . In the meantime, @vprigent , thanks for taking this on. Since Ruby 3.0 is EOL, it can be removed from here data-migrate/.github/workflows/build.yml Line 14 in 4927b56 after the build passes, I can deploy rc release for this change |
|
I'm somewhat invested into having up-to-date tools, so I can probably help with handling updates, deprecations and PRs which solve some of the obvious issues. Can't promise anything proactive in terms of evolution or making decision that'd affect the way this gem works, though. |
|
I can help also! |
|
I am available to help as well |
|
thanks folks, please send me an email @gmail and i can add you to maintainer group and slack channel for maintainers (not much action there, but easier to coordinate) |
vprigent
force-pushed
the
rails-7.2-update
branch
from
87b9660 to
e4aefab
Compare
vprigent
force-pushed
the
rails-7.2-update
branch
from
07d377a to
55b86f6
Compare
|
Hi folks, good to see there's some attention and motivation to maintain the project. I've updated the CI config to reflect the Ruby 3.0 deprecation. I believe this is ready to be merged. |
|
Mind updating your branch? |
|
✅ I've been using this branch successfully in Rails 7.2 beta2 |
Co-authored-by: Ronan <[email protected]>
Co-authored-by: Ronan <[email protected]>
This brings support for Rails 7.2 connection configuration changes.
CI fails because Ruby 3.0 isn't compatible with Rails 7.2
activesupport-7.2.0.beta1 requires ruby version >= 3.1.0, which is incompatibleI'd be keen to learn of a way around that if there is one?
Also noted, Ruby 3.0 is EOL'd, so a possible solution might be to drop it?