Import OS-specific variables in common role

We've relied on ansible's ability to use host-based facts to include variables for quite some time. This functionality is apparently not supported and has been silently failing for a while now. If you run your playbooks with -vvvv you will see messages like: skipping vars_file 'vars/{{ ansible_os_family }}.yml' due to an undefined variable The solution seems to be to move these includes to an include_vars task inside the role. The "always" tag means it always runs. See: ansible/ansible#28024
ilri · Nov 19, 2017 · 489e1c2 · 489e1c2
1 parent e24b1d9
commit 489e1c2
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 12 deletions.
diff --git a/compute.yml b/compute.yml
@@ -5,9 +5,7 @@
   become: yes
   remote_user: provisioning
   vars_files:
-    - "vars/{{ ansible_os_family }}.yml"
     - private/vars/common.yml
-    - "private/vars/{{ ansible_os_family }}.yml"
     - private/vars/ipsets.yml
   roles:
     - common

diff --git a/dspace.yml b/dspace.yml
@@ -5,10 +5,8 @@
   become: yes
   remote_user: provisioning
   vars_files:
-    - "vars/{{ ansible_os_family }}.yml"
     - private/vars/common.yml
     - private/vars/dspace.yml
-    - "private/vars/{{ ansible_os_family }}.yml"
     - private/vars/ipsets.yml
   roles:
     - common

diff --git a/nomads.yml b/nomads.yml
@@ -5,9 +5,7 @@
   become: yes
   remote_user: provisioning
   vars_files:
-    - "vars/{{ ansible_os_family }}.yml"
     - private/vars/common.yml
-    - "private/vars/{{ ansible_os_family }}.yml"
     - private/vars/ipsets.yml
   roles:
     - common

diff --git a/roles/common/tasks/main.yml b/roles/common/tasks/main.yml
@@ -1,4 +1,10 @@
 ---
+- name: Import OS-specific variables
+  include_vars: "{{ item }}"
+  with_items:
+    - "vars/{{ ansible_os_family }}.yml"
+    - "private/vars/{{ ansible_os_family }}.yml"
+  tags: always
 
 - name: Install common packages
   import_tasks: packages.yml

diff --git a/solr.yml b/solr.yml
@@ -4,9 +4,7 @@
   become: yes
   remote_user: provisioning
   vars_files:
-    - "vars/{{ ansible_os_family }}.yml"
     - private/vars/common.yml
-    - "private/vars/{{ ansible_os_family }}.yml"
     - private/vars/ipsets.yml
   roles:
     - common

diff --git a/storage.yml b/storage.yml
@@ -5,9 +5,7 @@
   become: yes
   remote_user: provisioning
   vars_files:
-    - "vars/{{ ansible_os_family }}.yml"
     - private/vars/common.yml
-    - "private/vars/{{ ansible_os_family }}.yml"
     - private/vars/ipsets.yml
   roles:
     - common

diff --git a/web.yml b/web.yml
@@ -5,9 +5,7 @@
   become: yes
   remote_user: provisioning
   vars_files:
-    - "vars/{{ ansible_os_family }}.yml"
     - private/vars/common.yml
-    - "private/vars/{{ ansible_os_family }}.yml"
     - private/vars/ipsets.yml
   roles:
     - common