Block storage query time filtering #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ilangofman <[email protected]>
Signed-off-by: ilangofman <[email protected]>
Signed-off-by: ilangofman <[email protected]>
…ofman/cortex into query_filtering_tombstones
Signed-off-by: ilangofman <[email protected]>
harry671003
reviewed
Aug 9, 2021
| return t, nil | ||
| } | ||
|
|
||
| func (w *Updater) isTombstoneForFiltering(t *cortex_tsdb.Tombstone) bool { |
There was a problem hiding this comment.
Shouldn't this be in tombstones.go?
harry671003
reviewed
Aug 16, 2021
| bkt: bucket.NewUserBucketClient(userID, bkt, cfgProvider), | ||
| logger: util_log.WithUserID(userID, logger), | ||
| bkt: bucket.NewUserBucketClient(userID, bkt, cfgProvider), | ||
| blocksDeletionDelay: deletionDelay, |
There was a problem hiding this comment.
Are these only used in isTombstoneForFiltering(). I don't think that method should belong in this class.
Signed-off-by: ilangofman <[email protected]>
Signed-off-by: ilangofman <[email protected]>
Signed-off-by: ilangofman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ilangofman [email protected]
What this PR does:
As part of the series deletion API proposal using block storage, this PR is responsible for implementing the query time filtering.
From the compactor, it writes to the bucket index the tombstones that are required for filtering. Afterwards, the queriers load the tombstones and apply the filtering using them.
Note: this is only implemented using the bucket index. If it is not enabled, then the query time filtering will not work (as per the proposal).
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]