Fixed MailBox._fetch_in_bulk bug

ikvk · Sep 29, 2020 · 395b74a · 395b74a
1 parent 0c4e33c
commit 395b74a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/docs/release_notes.rst b/docs/release_notes.rst
@@ -1,6 +1,7 @@
 0.24.0
 ======
 * Added MailBox.__init__ starttls argument for using STARTTLS
+* Fixed MailBox._fetch_in_bulk bug for empty self.search result
 
 0.23.0
 ======

diff --git a/imap_tools/mailbox.py b/imap_tools/mailbox.py
@@ -58,7 +58,10 @@ def _fetch_by_one(self, message_nums: [str], message_parts: str) -> iter:
             yield fetch_result[1]
 
     def _fetch_in_bulk(self, message_nums: [str], message_parts: str) -> iter:
-        fetch_result = self.box.fetch(','.join(message_nums), message_parts)
+        message_nums_str = ','.join(message_nums)
+        if not message_nums_str:
+            raise StopIteration()
+        fetch_result = self.box.fetch(message_nums_str, message_parts)
         check_command_status(fetch_result, MailboxFetchError)
         for built_fetch_item in grouper(fetch_result[1], 2):
             yield built_fetch_item