Don't convert to smiles for smarts svg drawing #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opened an issue in rdkit-js repo rdkit/rdkit-js#451 |
…than target should be smarts
RamziWeslati
force-pushed
the
fix/dont-convert-smiles-for-smarts-drawing
branch
from
db35fd5 to
220cc36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in storybook doesn't work.
For smarts
[#6][CH1](=O), it's doing a conversion to smilesC[CH]=O.get_svgis throwing anUncaughterror for this smarts and also the smiles when usingqmol.But, when doing a conversion
rdkit.get_qmol('[#6][CH1](=O)').get_smarts(), it gives me this smarts[#6][C&H1]=O, andget_qmol('[#6][C&H1]=O').get_svg()works.Another simpler example is
[n&H1]and[nH1]. It should be the same smarts (see the doc here https://www.daylight.com/dayhtml/doc/theory/theory.smarts.html), but idk why, the second one doesn't work with rdkit-js forget_svg.