Translate into visibility effect, Issue #9 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey great work , appreciate you for contributing but the translate effect comes into action when the last section starts to comes into view not when the trade and world section start to come into view |
|
Done, fixed the problem. Now it is working as needed. |
|
the translate effect for world section also occurs when only trade section is in view check this , you can make another isMidInView for world section and apply the translate effect when that comes into view |
|
@mohammedasimahmed, Done, added different refs for trade and world sections. Now they are appearing when they are in view saperately. |
|
pr accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animated the trade and world sections as described in the issue #9.