Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7 Implement Custom Modal for Confirming Task Deletion #24

Closed
wants to merge 1 commit into from

Conversation

piyushkumar079
Copy link

@piyushkumar079 piyushkumar079 commented Mar 16, 2024

#7

Implementing Custom React Modal

This PR addresses the issue of accidental task deletion by introducing an alert box to confirm task deletion actions. The addition of this confirmation mechanism aims to enhance user experience and prevent frustration caused by unintentional deletions.

Key Changes:

  • Implemented an Custom React Modal to prompt users for confirmation before deleting a task.
  • Ensured that the alert box provides a clear prompt with options to confirm or cancel the deletion action.

Screenshots/Video:

React.App.-.Google.Chrome.2024-03-16.23-21-27.mp4

@piyushkumar079 piyushkumar079 changed the title #7 Implement Alert Box for Confirming Task Deletion #7 Implement Custom Modal for Confirming Task Deletion Mar 16, 2024
@Yash7426
Copy link
Contributor

@piyushkumar079

Great job on the deleteTask() function! However, there's a small improvement we can make. Since handleClick() might involve asynchronous tasks, it's best to use async/await to ensure that handleClick() completes before moving on. Additionally, make sure not to close the modal until handleClick() is done executing.

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants