Adding nigerian zones and states #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phackstock
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good to me in principle thanks @erikfilias.
Just one small issue as explained below as well. The region names need to be unique for the Scenario Explorer and Niger already exists as a country. Therefore I'd recommend the prefix mentioned below.
Co-authored-by: Philip Hackstock <[email protected]>
Co-authored-by: Philip Hackstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This pull request aims to incorporate the six geopolitical zones and thirty-six states of Nigeria, along with the Federal Capital Territory, into the project's nomenclature. This addition will facilitate more region-specific analyses, data segmentation, and user interface enhancements tailored to Nigerian users or studies focusing on Nigeria.
Changes Made
I look forward to your feedback @phackstock and @sandrinecharousset.