-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create africa-interconnections.yaml #4
Conversation
potential list of interconnections between countries based on the list of countries with common border
@sandrinecharousset, there are a couple of things:
Some intercontinental interconnections should be included:
Some countries' names should be changed to the official recent ones:
Some countries are not included at all:
Finally, there are some listed interconnections that I think should be removed because they are not really "potential" (but it is up to you on this point):
|
removed duplicates added intercontinental interconnections corrected country names according to iso removed interco as suggested by @MohElabbas
@MohElabbas I did the changes as requested (thanks!), apart from changing name of Gambia as this is how it is named in the ISO we are following..... (I have absolutely no opinion about that, just want the whole stuff to be consistent.....) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one quick comment from my side.
@sandrinecharousset just to clarify, does your model report these two country regions? Because if not I'm not sure if we need to add them right now.
@@ -0,0 +1,227 @@ | |||
common_regions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The label common_regions is usually reserved for comparison regions between models.
I would suggest something more obvious like:
common_regions: | |
- Two country regions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to use a list format for this file. Meaning that common_regions
needs to be a list entry like so - common_regions
and all of the regions inside need to be indented by two spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to use a list format for this file. Meaning that
common_regions
needs to be a list entry like so- common_regions
and all of the regions inside need to be indented by two spaces
OK thanks, this wasn't absolutely clear to me , now I will not make the same mistake in the future :-)
@phackstock Yes!! Not only my model but nearly all models in the project. Interconnections are a central topic in this project as we have the power pools. And I can add that we don't only report results on these interco (such as the flows, the investments for increasing the intercos) but we also need data...... These directional regions were the main extension in the iamc dataformat that was made in open entrance. |
And I would add that we need to ensure consistency between these directional regions and the 3 regions from infrafair (all couples region>region in the infrafair list must be in the above list......) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandrinecharousset, I took the liberty of fixing your file format. Now it works.
@MohElabbas, looks good to me but if there's more details to check I'll hold off on the merge.
@phackstock All good from my side. |
Perfect, thanks @MohElabbas for the super quick confirmation. |
@phackstock Thanks, all good for me too |
potential list of interconnections between countries based on the list of countries with common border