-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repository name in CI workflow #904
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 46 46
Lines 4338 4338
=====================================
Hits 4148 4148
Misses 190 190 |
So the "Receive PR" workflow fails as expected since it's missing the label. However, I still triggered the "Pytest" workflow because the target is |
That seems like sound reasoning to me. Could you please try to make the change and see what happens? |
On it. What confuses me more is that the tests are actually passing, even though they should not have access to our secrets. Could this be because one doesn't need a license to access the cached GAMS installation? |
Pushing a commit without labeling the PR now triggers only the "Receive PR", "license/cla", and "Build package" tests. |
Adding the label gets "Receive PR" to pass, but the view of the tests here does not show that any of the other tests would be running now. The commit I used to trigger the update was the improvement @khaeru suggested here. EDIT: the test may be running, though, at least the RTD build passed now. Usually, Code quality should have passed already. |
Maybe these statuses are only reported back once the whole workflow finishes? So I think we should make a PR from within the IIASA repo to add the first two commits from this branch, then rebase this PR to see if it works as expected now. |
This PR aims to eventually fix how we run our CI workflows from forks. We want the tests to run only once and to be able to access our main repo's secrets if labelled correctly.
First, I'll not add any label to this PR, so it should not be able to access the secrets, which should make the tests fail.
Then I'll add the label and push something, which should trigger exactly one workflow: the "Receive PR" workflow should complete successfully, triggering one run of the tests with access to our secrets.
I'm not convinced this will work already because the trigger for
pytest.yaml
is also "on PR tomain
", so I'd have to look into combining this with "and not from within the head repo".How to review
Look at the triggered CI runs and check they align with our intentions.
PR checklist
Add or expand tests;coverage checks both ✅[ ] Add, expand, or update documentation.Just CI.[ ] Update release notes.Just CI.