-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation instructions #720
Conversation
* Recommend libmamba solver * Correct dependency arguments for pip * Recommend adding the main repo as remote upstream
@khaeru Do you think we should mention not installing jpype version 1.4.1 in the installation instructions? I was thinking of adding that to the 'known issues', but then I saw that you removed the temporary workaround in iiasa/ixmp#463, so I don't know if this is still relevant? |
Codecov Report
@@ Coverage Diff @@
## main #720 +/- ##
=====================================
Coverage 94.4% 94.4%
=====================================
Files 43 43
Lines 3448 3448
=====================================
Hits 3257 3257
Misses 191 191 |
It appears to have resolved itself. Both the ixmp and message-ix "pytest" CI workflows appear to be using JPype1 v1.4.1, and test_del_ts is passing. We don't have a concrete understanding of what was causing the issue: we only know that it appeared around the time JPype1 v1.4.1 appeared. tl;dr—I'd agree with your judgement that we don't need to specifically mention it in the install instructions. |
Thanks @glatterf42! 🚀 |
Closes #698 and #718. According to the notes I gathered during recent installation/CI runs, this PR
upstream
and fetches the tags from thereHow to review
PR checklist
Except for
macos-latest-py3.7
per Track/work around actions/setup-python#682 ixmp#484.Add or expand tests;coverage checks both ✅Update release notes.Not applicable.