Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Test enforce nightly #612

Closed
wants to merge 2 commits into from
Closed

Conversation

OFR-IIASA
Copy link
Contributor

This PR tests to see if a fix of models.py results in all nightly tests passing.

DO NOT MERGE DESPITE BEING APPROVED

@OFR-IIASA OFR-IIASA requested a review from gidden May 25, 2022 11:26
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #612 (3b224d4) into main (b572cce) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #612   +/-   ##
=====================================
  Coverage   92.8%   92.9%           
=====================================
  Files         42      43    +1     
  Lines       3287    3386   +99     
=====================================
+ Hits        3052    3147   +95     
- Misses       235     239    +4     
Impacted Files Coverage Δ
message_ix/message_ix/models.py 96.8% <0.0%> (-3.2%) ⬇️
message_ix/message_ix/core.py 95.1% <0.0%> (-0.1%) ⬇️
message_ix/message_ix/tests/test_core.py 100.0% <0.0%> (ø)
..._ix/tests/test_feature_vintage_and_active_years.py 100.0% <0.0%> (ø)

Copy link
Member

@gidden gidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving review to trigger nightlies

@khaeru
Copy link
Member

khaeru commented May 30, 2022

This fix was implemented and merged in #613.

@khaeru khaeru closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants