-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .tools.check() #506
Draft
khaeru
wants to merge
9
commits into
main
Choose a base branch
from
feature/check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add .tools.check() #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #506 +/- ##
=======================================
+ Coverage 93.4% 93.5% +0.1%
=======================================
Files 38 41 +3
Lines 2853 2967 +114
=======================================
+ Hits 2666 2776 +110
- Misses 187 191 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function
message_ix.tools.check()
.This function does pre-solve checks on MESSAGE-scheme scenarios: it examines the contents of a Scenario object and returns failure or warning if the contents of the Scenario are not compatible with the MESSAGE GAMS implementation and will certainly or likely cause an error if
Scenario.solve()
is called.Details:
message_ix/message_ix/model/MESSAGE/data_load.gms
Lines 175 to 177 in 900a9f8
Since GAMS is not a general-purpose programming language, checks in Python with more sophisticated checks and informative error messages can be easier to write and maintain.
check()
method returns a list of Result objects. This is a simple class that includes a description of the check, the outcome (pass, fail, warning) and optional informative messages that can explain the offending contents of the scenario.message_ix.reporting
(ultimatelygenno
) internally.How to review
PR checklist
technical_lifetime
→ error in scaling_investment_costs.gms #503