Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust models.MESSAGE for iiasa/ixmp#212 #311

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Feb 25, 2020

iiasa/ixmp#212 adds a feature to the ixmp.model.GAMSModel class, allowing a temporary directory for input and output GDX files, listing files, etc.

This feature is used for e.g. ixmp's DantzigModel; but it is not desired for MESSAGE models, where the user may want to inspect the GDX files. This PR explicitly disables the feature for MESSAGE, MESSAGE_MACRO, etc.

How to review

PR checklist

  • Tests added. N/A, no change in behaviour
  • Documentation added. N/A
  • Release notes updated. N/A

@khaeru khaeru self-assigned this Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #311   +/-   ##
======================================
  Coverage    79.8%   79.8%           
======================================
  Files          13      13           
  Lines        1144    1144           
======================================
  Hits          913     913           
  Misses        231     231
Impacted Files Coverage Δ
message_ix/models.py 98.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e630c...5efb731. Read the comment docs.

@khaeru khaeru merged commit d696263 into iiasa:master Feb 27, 2020
@khaeru khaeru deleted the feature/ixmp-model-init branch February 27, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant