Move DAC module's tools.costs assumptions into their own CSV files
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the DAC technologies' cost reduction and reduction scenarios assumptions are added to the `energy` module's CSV files. With #255, there is now the functionality to add module-specific cost assumptions. So I am moving the DAC technologies' cost reduction categories and reduction scenarios to its own module directory.
measrainsey
added
costs
glatterf42
approved these changes
Dec 18, 2024
|
Also looks good from my side. Thanks, Meas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to reorganize @ywpratama's DAC costs inputs
When @ywpratama initially added the DAC costs assumptions for #235, the new DAC technologies were added to the energy module's cost input CSVs, as at the time the costs tool didn't have the ability to take custom cost assumptions for the modules. Since then, #255 was merged into main and now the costs tool allows for module-specific costs assumptions. I have moved the DAC technologies' reduction rate categories and scenario reduction assumptions out of the energy module's directory into the DAC module's directory.
Additionally, this PR should help to address the issue raised by @khaeru in his comment here: due to another cost reduction category being added for other technologies but not the DAC technologies, this led to a problem where the DAC technologies were missing a value in the input CSV.
I also added the
dacmodule to the type hints in functions that require module as an input.How to review
For @ywpratama : Can you confirm if these cost assumptions are correct for the DAC module and nothing was incorrectly transferred over?
For @khaeru and/or @glatterf42 : In case you want to take a look as well?
PR checklist
None I believe as this is won't be merged to
main.