-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm support for Python 3.13 and drop 3.8 #250
Conversation
- Add explicit test of released versions ixmp/message-ix 3.9.0.
d33527d
to
593cbe2
Compare
abfcb42
to
df4bad7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
- Coverage 76.5% 75.6% -1.0%
=======================================
Files 203 203
Lines 15578 15600 +22
=======================================
- Hits 11927 11801 -126
- Misses 3651 3799 +148
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is looking great :)
I hope it also explains all CI failures today, as in: GAMS was bumped here, requiring a different license, but the nightly tests and test-snapshot still wanted to use the older version requiring the older license, and failed. In that case, I'd just ask to please also adapt the snapshot-workflow file to use the newer GAMS version :)
Ah good catch—will do. |
This is the earliest version that has builds for macOS arm64.
- Use standard collections, e.g. list[str] instead of typing.List[str]. - Import certain types from collections.abc, instead of deprecated aliases in typing. - Omit .model.transport, handled in #225.
Available from Python 3.9 onwards.
- mypy 1.11.0 → 1.13.0 - ruff 0.5.5 → 0.7.4 - "ruff format" one file. - Exclude two .ipynb files from "ruff check".
Use a maintained and updated version.
Only skip install on macos-13; allow on macos-latest.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
Same work-around for pyam-iamc packaging issue as in .github/workflows/pytest.yaml; see #250.
message-ix-models
is compatible with the new version. This includes:list[str]
instead offrom typing import List
/List[str]
.from collections.abc import Sequence
et al instead of deprecatedfrom typing import Sequence
.How to review
PR checklist
Add, expand, or update documentation.N/A