Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "macos-13" runner in "pytest" workflow #184

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Use "macos-13" runner in "pytest" workflow #184

merged 1 commit into from
Apr 23, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Apr 23, 2024

This PR is identical to iiasa/ixmp#527, see there for an extensive background description.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation.
  • [ ] Update doc/whatsnew.

@glatterf42 glatterf42 added the ci Continuous integration & testing label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.7%. Comparing base (ee15eeb) to head (7f7585a).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #184   +/-   ##
=====================================
  Coverage   76.7%   76.7%           
=====================================
  Files        112     112           
  Lines       7154    7154           
=====================================
  Hits        5494    5494           
  Misses      1660    1660           

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checks pass. Please also update the branch protection rule.

@glatterf42 glatterf42 merged commit 38aa6e9 into main Apr 23, 2024
26 checks passed
@glatterf42 glatterf42 deleted the ci/macos-13 branch April 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration & testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants