-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous enhancements for 2023-W44 #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
--nodes is now stored on Context automatically.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
+ Coverage 73.3% 74.3% +0.9%
=======================================
Files 82 89 +7
Lines 5663 5942 +279
=======================================
+ Hits 4155 4416 +261
- Misses 1508 1526 +18
|
This avoids triggering import side-effects until the user actually runs the command. Also expand docstring.
Add CliRunner.add_command()
Use function-scoped test_context to avoid polluting session_context.
- Use existing test tools instead of monkeypatch. - Share a pytest mark with test_workflow().
- Remove unused "_base_url" key. - Scope to individual test function. - Adjust usage in test_workflow(): the "base" key now has a platform name, so can be truncated.
khaeru
added a commit
that referenced
this pull request
Nov 4, 2023
khaeru
added a commit
that referenced
this pull request
Nov 4, 2023
khaeru
added
water
MESSAGEix-Nexus (water) variant
structure
Infomation and metadata about model structure
report
genno-based reporting and post-solve processing
labels
Nov 14, 2023
khaeru
force-pushed
the
enh/2023-W44
branch
5 times, most recently
from
November 22, 2023 23:58
6f9d1b3
to
4c59e0d
Compare
khaeru
added a commit
that referenced
this pull request
Nov 23, 2023
Use forms that are robust to 'reporting' → 'report' rename.
- Import RENAME_DIMS through a function that provides backwards compatibility. - Use MESSAGE.items and MACRO.items; remove redefinitions. - Simplify simulate_qty() to accept a list of dimensions directly.
Replace manual version checks and marks with this utility.
This remains disabled, as it cannot handle wrapper_descriptor.
Enable nitpicky, napoleon_preprocess_types
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iamc_like_data_for_query()
:archive_member
..project.advance
, an exogenous data source for the ADVANCE project database, fuzzed data for testing, tests. Supersedes.tools.advance
..tools.advance._fuzz_data()
to mix-models testing fuzz-private-data, usable for SSP, ADVANCE, and other data sources..tools.iamc.describe()
to generate code lists given data in the IAMC structure..workflow.make_click_command()
to automatically generate a CLI for any Workflow.fetch
CLI command; supersedesmessage_data.tools.download
and the narrowermessage_ix_models.snapshot
CLI.message_ix_models/data/water/
files from packaging; this shrinks the package from >20 MB to <5 MB.report.computations
→report.operator
(cf. Change term ‘computations’? khaeru/genno#34, Add an Operator class khaeru/genno#98, Rename 'report', 'util' + miscellaneous clean-ups ixmp#500)..report
.How to review
Read the diff and note that the CI checks all pass.
PR checklist