Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the nexus module #106

Merged
merged 57 commits into from
Sep 12, 2024

Updating whatsnew

5b616f0
Select commit
Loading
Failed to load commit list.
Merged

Update the nexus module #106

Updating whatsnew
5b616f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2024 in 0s

65.5% (+6.0%) compared to 32cb2fd

View this Pull Request on Codecov

65.5% (+6.0%) compared to 32cb2fd

Details

Codecov Report

Attention: Patch coverage is 86.11521% with 94 lines in your changes missing coverage. Please review.

Project coverage is 65.5%. Comparing base (32cb2fd) to head (5b616f0).

Files with missing lines Patch % Lines
message_ix_models/model/water/report.py 17.8% 60 Missing ⚠️
...essage_ix_models/model/water/data/water_for_ppl.py 84.3% 10 Missing ⚠️
message_ix_models/model/water/data/water_supply.py 81.3% 8 Missing ⚠️
message_ix_models/model/water/data/demands.py 89.0% 6 Missing ⚠️
message_ix_models/model/water/utils.py 50.0% 4 Missing ⚠️
message_ix_models/model/water/cli.py 66.6% 3 Missing ⚠️
message_ix_models/tests/model/water/test_report.py 93.1% 2 Missing ⚠️
message_ix_models/tests/model/water/test_build.py 97.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #106     +/-   ##
=======================================
+ Coverage   59.5%   65.5%   +6.0%     
=======================================
  Files        195     203      +8     
  Lines      15491   15819    +328     
=======================================
+ Hits        9225   10375   +1150     
+ Misses      6266    5444    -822     
Files with missing lines Coverage Δ
message_ix_models/model/water/__init__.py 100.0% <100.0%> (ø)
message_ix_models/model/water/build.py 91.4% <100.0%> (+76.4%) ⬆️
message_ix_models/model/water/data/__init__.py 95.0% <100.0%> (+31.8%) ⬆️
...ssage_ix_models/model/water/data/infrastructure.py 100.0% <100.0%> (+95.9%) ⬆️
message_ix_models/model/water/data/irrigation.py 100.0% <100.0%> (+85.1%) ⬆️
...e_ix_models/tests/model/water/data/test_demands.py 100.0% <100.0%> (ø)
...dels/tests/model/water/data/test_infrastructure.py 100.0% <100.0%> (ø)
...x_models/tests/model/water/data/test_irrigation.py 100.0% <100.0%> (ø)
...odels/tests/model/water/data/test_water_for_ppl.py 100.0% <100.0%> (ø)
...models/tests/model/water/data/test_water_supply.py 100.0% <100.0%> (ø)
... and 11 more

... and 4 files with indirect coverage changes