Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up initial packaging #1

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Set up initial packaging #1

merged 9 commits into from
Jun 16, 2023

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jun 4, 2023

As discussed on Friday 02 June.

In addition, I:

How to review

@Zh-xy @amastrucci I ask for approving reviews from each of you to confirm that you:

  • View the list of commits and messages
  • View the changed files, and inspect the file layout on this branch.
  • View the added and expanded documentation pages, and confirm they are clear about how to obtain and work with the code.

Please ask any questions if the above are not clear or you need further information.

@khaeru khaeru self-assigned this Jun 4, 2023
@khaeru
Copy link
Member Author

khaeru commented Jun 4, 2023

FYI also @glatterf42.

@Zh-xy Zh-xy requested review from Zh-xy and removed request for Zh-xy June 16, 2023 08:51
@amastrucci
Copy link
Collaborator

Thanks Paul, looks good to me! We can merge this to the main branch, but we will need to check later how to merge with the new developments we are working on.

@glatterf42 glatterf42 merged commit 6dd43df into main Jun 16, 2023
@glatterf42 glatterf42 deleted the packaging branch June 16, 2023 12:18
@glatterf42
Copy link
Member

If you have started branches from some commit at main before this PR was merged, you may now need to reconcile these branches with the latest changes. You could rebase your branches on to the new state of main or you merge the changes of main into your branches - this is mostly up to you. Merging will create an additional commit, while rebasing will keep the commit history linear (so the history of the repo is easier to understand). If you don't feel comfortable rebasing your branches, please just let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants