-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce run.optimization.remove_solution()
#139
Open
glatterf42
wants to merge
7
commits into
main
Choose a base branch
from
enh/run-remove-solution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=====================================
Coverage 86.9% 87.0%
=====================================
Files 230 230
Lines 8156 8162 +6
=====================================
+ Hits 7095 7101 +6
Misses 1061 1061
|
glatterf42
force-pushed
the
remove/pointless-tabulate-parameter
branch
from
November 29, 2024 13:23
50d6fae
to
79b2c14
Compare
glatterf42
force-pushed
the
enh/run-remove-solution
branch
from
November 29, 2024 13:24
aece6a0
to
6ebef60
Compare
glatterf42
changed the title
Introduce
Introduce Nov 29, 2024
run.optimization.remove_ solution()
run.optimization.remove_solution()
glatterf42
force-pushed
the
remove/pointless-tabulate-parameter
branch
from
December 19, 2024 11:12
79b2c14
to
bc61725
Compare
glatterf42
force-pushed
the
enh/run-remove-solution
branch
from
December 19, 2024 11:36
6ebef60
to
ba074b7
Compare
glatterf42
force-pushed
the
enh/run-remove-solution
branch
from
December 19, 2024 12:42
ba074b7
to
b0201c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of cleaning up #101. It introduces the
run.optimization.remove_solution()
in the core layer, which removes all data of all equations and variables belonging to the run.It also includes various small clean-ups that arose from the reviews of #101.