-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping for 2024-W13 #524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for genno ≥ 1.25.0
- Apply ruff v0.3.4 to 8 files. - Move ruff configuration settings to current (non-deprecated) locations.
khaeru
added
enh
New features & functionality
docs
Documentation, tutorials, etc.
ci
Continuous integration
labels
Mar 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=====================================
Coverage 98.9% 98.9%
=====================================
Files 44 44
Lines 4795 4804 +9
=====================================
+ Hits 4743 4754 +11
+ Misses 52 50 -2
|
- Reduce mypy exclusions in pyproject.toml. - Add pandas-stubs to type hint packages.
…to resolve references to genno.Quantity & co.
khaeru
force-pushed
the
enh/2024-W13
branch
2 times, most recently
from
March 28, 2024 10:18
dbfcd3c
to
00f1ef6
Compare
- Correct typing of Scenario.add_set(…, comment=…) and simplify handling. - as_str_list() always returns list. - Remove "pragma: no cover" on TYPE_CHECKING blocks.
- Mark one additional exception. - Update exceptions.
glatterf42
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me :)
Hm, not great that the Jupyter-based tests are consistently failing here… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.__version__ = None
in show_versions().How to review
PR checklist
Update release notes.No change in functionality.