Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping for 2024-W13 #524

Merged
merged 13 commits into from
Mar 28, 2024
Merged

Housekeeping for 2024-W13 #524

merged 13 commits into from
Mar 28, 2024

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Mar 27, 2024

  • Adapt to genno 1.25.
  • Improve documentation cross-references using sphinx extensions provided by genno 1.26.
  • Bump ruff, mypy versions and remove outdated typing exclusions.
    • Adjust code to pass type checks with pandas-stubs.
  • Handle package.__version__ = None in show_versions().
  • Add dependabot config for GitHub Actions used in workflows.
  • Bump pre-commit action version to suppress GHA warnings.

How to review

  • Read the diff and note that the CI checks all pass.
  • View the preview build of the documentation, particularly the reporting page.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes. No change in functionality.

@khaeru khaeru self-assigned this Mar 27, 2024
@khaeru khaeru added enh New features & functionality docs Documentation, tutorials, etc. ci Continuous integration labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (d202e01) to head (0390fac).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #524   +/-   ##
=====================================
  Coverage   98.9%   98.9%           
=====================================
  Files         44      44           
  Lines       4795    4804    +9     
=====================================
+ Hits        4743    4754   +11     
+ Misses        52      50    -2     
Files Coverage Δ
ixmp/backend/__init__.py 100.0% <ø> (ø)
ixmp/backend/io.py 98.5% <100.0%> (ø)
ixmp/backend/jdbc.py 97.4% <ø> (ø)
ixmp/core/platform.py 98.9% <ø> (ø)
ixmp/core/scenario.py 99.6% <100.0%> (+0.8%) ⬆️
ixmp/core/timeseries.py 98.6% <100.0%> (-0.1%) ⬇️
ixmp/report/operator.py 99.0% <100.0%> (ø)
ixmp/testing/__init__.py 95.9% <ø> (ø)
ixmp/testing/data.py 97.2% <100.0%> (-0.1%) ⬇️
ixmp/testing/jupyter.py 100.0% <ø> (ø)
... and 10 more

khaeru added 5 commits March 27, 2024 17:19
- Reduce mypy exclusions in pyproject.toml.
- Add pandas-stubs to type hint packages.
…to resolve references to genno.Quantity & co.
@khaeru khaeru force-pushed the enh/2024-W13 branch 2 times, most recently from dbfcd3c to 00f1ef6 Compare March 28, 2024 10:18
khaeru added 2 commits March 28, 2024 11:55
- Correct typing of Scenario.add_set(…, comment=…) and simplify
  handling.
- as_str_list() always returns list.
- Remove "pragma: no cover" on TYPE_CHECKING blocks.
- Mark one additional exception.
- Update exceptions.
Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me :)

@khaeru
Copy link
Member Author

khaeru commented Mar 28, 2024

Hm, not great that the Jupyter-based tests are consistently failing here…

@khaeru khaeru merged commit 5713fc1 into main Mar 28, 2024
21 checks passed
@khaeru khaeru deleted the enh/2024-W13 branch March 28, 2024 15:25
@khaeru khaeru mentioned this pull request Mar 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration docs Documentation, tutorials, etc. enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants